-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux: Be more restrictive with executable name #806
Comments
executable name will be not changed and productName will be still used — please see electron/packager#297 (comment)
|
We already use if it is not important for you — If it is important for you — you want Should electron-builder force you to explicitly set So, |
Using I would still suggest you to e.g. convert |
|
Very good. So To summarize:
Right? |
Yes. Also, in any case, all file names are sanitised using https://www.npmjs.com/package/sanitize-filename |
@lbssousa Your are right. npm doesn't restrict name to be lowercased. But snaps does. So, electron-builder will lowercase your name in any case for all Linux targets. |
Please use the proper unchanged application names (including capitalization, if any) for AppImages like you do for macOS. Every time I see an application like e.g., RcloneTray spelled correctly ( Point in case: |
Currently electron-builder uses
productName
info for naming app's main executable, which may be painful for Linux binaries being run from command terminal, if that info contains uppercase letters, spaces, etc.I would like to suggest a new option
executableName
for Linux binaries, with the following restrictions:&
).If no
executableName
is provided inpackage.json
, electron-builder could calculate it fromname
orproductName
options (convert to lowercase, strip spaces, replace special characters with-
or_
, etc.).The text was updated successfully, but these errors were encountered: