Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and test user event serialisation #3912

Merged
merged 10 commits into from
Mar 18, 2024
Merged

Refactor and test user event serialisation #3912

merged 10 commits into from
Mar 18, 2024

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Feb 29, 2024 •
edited
Loading

This replaces the ad-hoc serialisation code for user event with schema-profunctor instances, like everything else, and introduces golden tests for them. The JSON golden files were generated using the old code to ensure this refactoring hasn't changed anything.

https://wearezeta.atlassian.net/browse/WPB-6892

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti force-pushed the pcapriotti/golden-events branch from 2c4e3c5 to f8ebe3b Compare March 6, 2024 08:13
@pcapriotti pcapriotti marked this pull request as ready for review March 6, 2024 08:16
@pcapriotti pcapriotti force-pushed the pcapriotti/golden-events branch from f8ebe3b to 74575a2 Compare March 6, 2024 12:34
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 6, 2024
@pcapriotti pcapriotti force-pushed the pcapriotti/golden-events branch from a14bfe4 to 8ec8577 Compare March 11, 2024 08:28
battermann
battermann approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@battermann battermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would request to remove the empty file. The rest is just opinion and looks good otherwise. Approved in advance.

libs/brig-types/src/Brig/Types/User/Logging.hs Outdated Show resolved Hide resolved
libs/wire-api/src/Wire/API/UserEvent.hs Show resolved Hide resolved
services/brig/src/Brig/API/Connection.hs Outdated Show resolved Hide resolved
@pcapriotti pcapriotti force-pushed the pcapriotti/golden-events branch from 8ec8577 to d7fcfdc Compare March 15, 2024 09:16
@pcapriotti pcapriotti merged commit b85133f into develop Mar 18, 2024
8 checks passed
@pcapriotti pcapriotti deleted the pcapriotti/golden-events branch March 18, 2024 14:06
@zebot zebot mentioned this pull request Apr 25, 2024
Merged
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battermann battermann battermann approved these changes

Assignees
No one assigned
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcapriotti @battermann @zebot