-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish servantifying brig #3996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
label
Apr 13, 2024
akshaymankar
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets gooooo 🚀
This gets it into swagger. Also get rid of unnecessary newtype wrapper
fisx
force-pushed
the
wpb8691-servantify
branch
from
April 15, 2024 18:41
f8631fb
to
ca09f4e
Compare
happens locally and on CI, but only on this branch, not on develop. |
MangoIV
force-pushed
the
wpb8691-servantify
branch
from
April 16, 2024 08:25
789bc4b
to
b2711e8
Compare
MangoIV
force-pushed
the
wpb8691-servantify
branch
from
April 16, 2024 08:40
b2711e8
to
c0679f0
Compare
akshaymankar
approved these changes
Apr 16, 2024
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
More specific category, to highlight Technical Debt being tackled.
label
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: technical-roadmap/technical-debt
More specific category, to highlight Technical Debt being tackled.
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-8691
Checklist
changelog.d