Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish servantifying brig #3996

Merged
merged 10 commits into from
Apr 16, 2024
Merged

Finish servantifying brig #3996

merged 10 commits into from
Apr 16, 2024

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Apr 13, 2024

https://wearezeta.atlassian.net/browse/WPB-8691

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 13, 2024
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets gooooo 🚀

@fisx fisx force-pushed the wpb8691-servantify branch from f8631fb to ca09f4e Compare April 15, 2024 18:41
@fisx
Copy link
Contributor Author

fisx commented Apr 15, 2024

Federator.API
  Inward
    should return 404 'no-endpoint' response from Brig [✘]

Failures:

  test/integration/Test/Federator/InwardSpec.hs:100:13: 
  1) Federator.API.Inward should return 404 'no-endpoint' response from Brig
       uncaught exception: ErrorCall
       Missing response body.

  To rerun use: --match "/Federator.API/Inward/should return 404 'no-endpoint' response from Brig/"

happens locally and on CI, but only on this branch, not on develop.

@MangoIV MangoIV force-pushed the wpb8691-servantify branch from 789bc4b to b2711e8 Compare April 16, 2024 08:25
@MangoIV MangoIV self-assigned this Apr 16, 2024
@MangoIV MangoIV force-pushed the wpb8691-servantify branch from b2711e8 to c0679f0 Compare April 16, 2024 08:40
@MangoIV MangoIV merged commit 5293202 into develop Apr 16, 2024
8 checks passed
@MangoIV MangoIV deleted the wpb8691-servantify branch April 16, 2024 11:23
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants