Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ldap-scim-bridge chart in wire release #3999

Merged
merged 3 commits into from
Apr 15, 2024
Merged

add ldap-scim-bridge chart in wire release #3999

merged 3 commits into from
Apr 15, 2024

Conversation

amitsagtani97
Copy link
Contributor

@amitsagtani97 amitsagtani97 commented Apr 15, 2024 •
edited
Loading

Checklist

https://wearezeta.atlassian.net/browse/WPB-7170

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Apr 15, 2024
@supersven supersven self-requested a review April 15, 2024 10:00
supersven
supersven approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the spelling mistake, LGTM 👍

@amitsagtani97 amitsagtani97 merged commit fdb1c1c into develop Apr 15, 2024
8 checks passed
@amitsagtani97 amitsagtani97 deleted the add_ldap_in_release branch April 15, 2024 11:01
@zebot zebot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supersven supersven supersven approved these changes

@julialongtin julialongtin Awaiting requested review from julialongtin

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amitsagtani97 @supersven @zebot