Refactor ciphersuite handling for 1-1 convs #4009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcapriotti
changed the base branch from
develop
to
pcapriotti/new-mls-ciphersuites
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
pcapriotti/mls-one-to-one-ciphersuite
branch
from
add454e to
332a1d6
Compare
pcapriotti
force-pushed
the
pcapriotti/mls-one-to-one-ciphersuite
branch
2 times, most recently
from
e66f1ac to
1bc60de
Compare
This changes the conversation and subconversation metadata so that epoch, epoch timestamp and ciphersuites are all simultaneously optional. This makes it possible not to set a ciphersuite for conversations until they receive a commit.
pcapriotti
force-pushed
the
pcapriotti/mls-one-to-one-ciphersuite
branch
from
1bc60de to
540ed8b
Compare
stefanwire
approved these changes
Apr 29, 2024
pcapriotti
added a commit
that referenced
this pull request
May 8, 2024
* Introduce ActiveMLSConversationData This changes the conversation and subconversation metadata so that epoch, epoch timestamp and ciphersuites are all simultaneously optional. This makes it possible not to set a ciphersuite for conversations until they receive a commit. * Fix assertions in integration tests * Add more versioned conversation endpoints * Make SubConversation record versioned * Adapt galley to versioning changes * Adapt and expand conversation golden tests * Fix arbitrary instance of ConversationMLSData * Test old versions of conversation metadata * Restore epoch field in Conversation serialisation * Add CHANGELOG entry * Lint * Test MLS 1-1 with other ciphersuites * Fix assertion in galley integration test * fixup! Fix assertion in galley integration test
pcapriotti
added a commit
that referenced
this pull request
May 8, 2024
* Refactor ciphersuite handling for 1-1 convs (#4009) * Introduce ActiveMLSConversationData This changes the conversation and subconversation metadata so that epoch, epoch timestamp and ciphersuites are all simultaneously optional. This makes it possible not to set a ciphersuite for conversations until they receive a commit. * Fix assertions in integration tests * Add more versioned conversation endpoints * Make SubConversation record versioned * Adapt galley to versioning changes * Adapt and expand conversation golden tests * Fix arbitrary instance of ConversationMLSData * Test old versions of conversation metadata * Restore epoch field in Conversation serialisation * Add CHANGELOG entry * Lint * Test MLS 1-1 with other ciphersuites * Fix assertion in galley integration test * fixup! Fix assertion in galley integration test * Improve MLS one2one conversation test
2 tasks
echoes-hq
bot
added
echoes: technical-roadmap/security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
MLSConversationDatarecord so that epoch, epoch timestamp and ciphersuites are not present when the epoch is 0. Several endpoints have been updated to version 6 as a result of the API incompatibility introduced by this change.https://wearezeta.atlassian.net/browse/WPB-8692
Checklist
changelog.d