-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User subsystem: add profile update operations #4046
Merged
Merged
Changes from 35 commits
Commits
Show all changes
134 commits
Select commit
Hold shift + click to select a range
8c4ec63
UpdateUser operation; work on Error sub-effects.
pcapriotti 2b044a8
Fix build
pcapriotti 1e17a86
Rename onUserEvent → generateUserEvent
pcapriotti a1352a4
Use state effect for local users in mini backends
pcapriotti 0466072
Implement user update in mini backends
pcapriotti 478693d
Add user update property test
pcapriotti 7d70e79
[feat] rethrow errors as wai errors
MangoIV 6d6695c
[feat] test behaviour if user is managed by scim
MangoIV 1ed40db
[feat] set galley api access
MangoIV 17b5155
[feat] test all of the update record members
MangoIV 619d032
[feat] interpret user events
MangoIV b34debf
Use MiniBackend state effect in mini-backend stack
pcapriotti e58521e
Add fake event interpreter
pcapriotti 9ee4efe
Add Arbitrary instance for AllowSCIMUpdates
pcapriotti 2bbb388
Replace UserUpdate with a new type
pcapriotti dc57f85
Use update functionality in brig
pcapriotti 898b917
Add locale update to user subsystem
pcapriotti 696342a
Move allowScim argument to update structure
pcapriotti 11dc928
Add handle update functionality to UserSubsystem
pcapriotti e38f08b
Make sure NotPending users have an identity
pcapriotti 8c79463
Check claimed handles
pcapriotti 3f3ac72
Implement handle lookup in mini backend
pcapriotti 8f211d8
Add DeleteUser action to UserStore
pcapriotti 9617c93
Add some TODOs
pcapriotti 1ea9657
Lint and format
elland 189d545
Added missing where clause.
elland 0c96894
Fixed tombstone.
elland ff4a366
Renamed cql query function for clarity.
elland 89d4024
usersubsystems: added handle parsing text.
elland 7fb0676
Formatting.
elland 4f55d8a
UserSubsystems: Added prop tests for handles.
elland 8d42e40
lint
elland 5623de1
UserSubsystem: added scim handle update tests.
elland b536183
added changelog
elland 70b32c7
Added update supported protocols.
elland 8e02e24
[stash]
fisx a98058f
...
fisx e72c7d7
...
fisx db9db70
...
fisx 8630333
Fix.
fisx 86565b0
TODO.
fisx 0c7e31d
Fix 2 test cases.
fisx f98c6d0
Fixed property test.
elland 7c79cb6
Deleted repeated lines.
elland 4f1ec69
Regen nix.
elland 9a2764f
Removed ambiguity.
elland 5061acb
Updated call sites.
elland 2dd847d
Remove bogus (and unnecessary) -Wwarn pragma.
fisx bc049fb
explicit imports, exports.
fisx 64c3de9
Removed outdated FUTUREWORK.
fisx 0523868
Typo.
fisx 45ddd8d
Make leaking interpreter implementation into brig more explicit.
fisx 7faed02
Drive-by fix.
fisx 00fcb9f
Send handle update events.
fisx 8441af9
Fixup bc049fbc144938e9e42d3c5b313f369b5d885e2a
fisx 872f9fb
Fixup 00fcb9f2135e2a54dd9d3d9691786289d8a418f6
fisx 23d85a9
Fixup bc049fbc144938e9e42d3c5b313f369b5d885e2a
fisx c9fdec2
Test for update supportedProtocols.
fisx dc59c26
Update supportedProtocols [wip]
fisx 145e364
Fixed test for supported protocols.
elland 840d625
WIP: fix permissio checks
elland 6d2c2f5
Move BadHandle type and qc generator to types-common.
fisx f6d1840
Fix handle update for blocklisted handles.
fisx 5a4f836
Make supported-protocols update test a property.
fisx 1f8e2b3
Fix more failing test cases (same pattern as before).
fisx 5077b89
Simplify checkHandle test
akshaymankar 92d37f7
UserSubsystem: Implement GetSelfProfile
akshaymankar 10c7282
UserSubsystem.updateUserProfile: Add assertion for updating locale
akshaymankar 1af8eeb
Remove TODO deemed requiring discussion
akshaymankar 8d85bef
UserSubsystem: Implement GetSelfProfile
akshaymankar 0644bd5
Merge remote-tracking branch 'origin/develop' into update-profile
fisx 431dc3e
Rename names.
fisx 20d020c
Re-align userstore and user subsystem interfaces around handle.
fisx 95c0895
Rm some boolean blindness.
fisx 68e9cfb
Rename names (really bad ones this time...).
fisx 19af787
Fix UpdateOriginType values in brig api.
fisx 8f111d2
rm TODO.
fisx a204ee3
Add TODOs.
fisx ac171fc
Fix TODO syntax :)
fisx c263709
Deprioritize TODO.
fisx 83bbf0e
Haddocs.
fisx 125c6bb
Merge remote-tracking branch 'origin/develop' into update-profile
fisx 08e382b
Improve error message for invalid handles.
fisx 6a1b88b
Rename names.
fisx f2cf6db
Note on db performance.
fisx 59e5bba
Remove unproducable error.
fisx 2f21e55
Haddocks.
fisx 73c2d3d
Remove misguided TODOs.
fisx 49fd0c0
Fix: update locale by client not allowed if user is managed by scim.
fisx f875082
Fix names.
fisx a45671f
remove more low-prio TODOs.
fisx 103f48f
Resolve TODO.
fisx b6b8781
Add test for locale update under scim management.
fisx b22d481
Fix test.
fisx 3aab327
Fix tests, add happy path for profile update.
fisx 491611f
Fixup
fisx 0a79d96
Fix locale update.
fisx 8ebd1f7
Rm dead code.
fisx 261a9cc
Typo
fisx 1fb67b1
Fix compiler errors.
fisx 1000b25
Rm dead code.
fisx be9bc67
Test coverage.
fisx 41224da
Fix missing fields in update event.
fisx abb1f9d
Dry-by fix: make responseJsonUnsafe more helpful when crashing.
fisx 992fe5d
hlint.
fisx a7f9f84
hlint. (?!)
fisx 58a639b
Polish haddocks.
fisx 9be4bdf
Changelog.
fisx 459e966
Make Handle data type abstract.
fisx 93cdaeb
Revert "Make Handle data type abstract."
fisx 99915bc
Move local function in where block.
fisx 4ee712c
Remove FUTUREWORK
fisx 07d53e5
Rename local function.
fisx 948b889
Fix test case.
fisx 49c0cf6
Merge remote-tracking branch 'origin/develop' into update-profile
fisx 555161e
remove obsolete changelog entry (this has been fixed in WPB-9488).
fisx 8c66230
Rm dead code from rest api.
fisx e039e95
Revert "Rm dead code from rest api."
fisx 79fe0e5
Update services/brig/test/integration/API/UserPendingActivation.hs
fisx 874d7ba
Merge remote-tracking branch 'origin/develop' into update-profile
fisx 149854d
Update services/brig/src/Brig/User/Auth.hs
fisx 88b0190
More guards in unit tests against invalid arbitrary values.
fisx 7fa4efa
Merge remote-tracking branch 'refs/remotes/origin/update-profile' int…
fisx 93ee32d
Fixup
fisx 4059bf9
Fix test case.
fisx 385a29a
Improve error message for `*ManagedByScim`.
fisx 298c406
Revert "Fix test case."
fisx 829c88a
Fix application logic around blocking updates because scim or e2eid.
fisx b9067a7
Merge remote-tracking branch 'origin/develop' into update-profile
fisx 5f50929
hlint.
fisx c40670e
failed attempt to port a galley test to /integration
fisx 66a9abc
Revert "failed attempt to port a galley test to /integration"
fisx f927d98
I think I found the problem with this test! (fix coming up)
fisx 4ac5de7
Small fix for legacy integration test.
fisx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Added profile update operations to the user subsystem. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to the error responses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshaymankar , Paolo replied to the same question I had. See the comments section on the main PR page.