Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPB-10058 delete phone column in brig's user table #4130

Merged
merged 13 commits into from
Jul 15, 2024
Merged

WPB-10058 delete phone column in brig's user table #4130

merged 13 commits into from
Jul 15, 2024

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Jul 8, 2024 •
edited
Loading

https://wearezeta.atlassian.net/browse/WPB-10058

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jul 8, 2024
@battermann battermann changed the title delete phone keys WPB-10058 delete phone column in brig's user table Jul 12, 2024
@battermann battermann marked this pull request as ready for review July 12, 2024 10:08
@battermann battermann marked this pull request as draft July 12, 2024 10:57
@battermann battermann marked this pull request as ready for review July 12, 2024 12:30
fisx
fisx approved these changes Jul 13, 2024
View reviewed changes
changelog.d/5-internal/WPB-10058 Outdated Show resolved Hide resolved
@akshaymankar
Copy link
Member

Perhaps there should also be docs about how to run this tool.

mdimjasevic
mdimjasevic approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, assuming we can read all the phone keys at once into memory.

tools/db/remove-phone-keys/src/RemovePhoneKeys/Lib.hs Outdated Show resolved Hide resolved
@mdimjasevic mdimjasevic merged commit feda42b into develop Jul 15, 2024
10 checks passed
@mdimjasevic mdimjasevic deleted the WPB-10058-delete-the-phone-column-in-brigs-user-db-table branch July 15, 2024 11:54
@zebot zebot mentioned this pull request Oct 9, 2024
Closed
This was referenced Oct 23, 2024
Closed
Closed
@zebot zebot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimjasevic mdimjasevic mdimjasevic approved these changes

@akshaymankar akshaymankar akshaymankar left review comments

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@battermann @akshaymankar @mdimjasevic @fisx @zebot