Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Deleted dangling phone references in Brig #4197

Merged
merged 2 commits into from
Aug 12, 2024
Merged

[chore] Deleted dangling phone references in Brig #4197

merged 2 commits into from
Aug 12, 2024

Conversation

elland
Copy link
Contributor

@elland elland commented Aug 12, 2024

Brig.API.User still had functions referencing phones unnecessarily.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 12, 2024
@elland elland merged commit 3f95261 into develop Aug 12, 2024
10 checks passed
@elland elland deleted the elland/remove-dangling-phone-funcs branch August 12, 2024 08:23
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Aug 13, 2024
@b1pb1p b1pb1p added echoes/initiative: wpb-4387-remove-phone-number... and removed echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elland @pcapriotti @b1pb1p @zebot