Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPB-11188] LegalHold support V1 #4284

Merged
merged 15 commits into from
Oct 10, 2024
Merged

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Oct 8, 2024

https://wearezeta.atlassian.net/browse/WPB-11188

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Oct 8, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 8, 2024
@battermann battermann force-pushed the WPB-11188-adopt-legal-hold-api-v-1 branch from b13e00a to 6ad53de Compare October 8, 2024 11:46
@elland elland force-pushed the WPB-11188-adopt-legal-hold-api-v-1 branch from d49b259 to 3f0b4a2 Compare October 9, 2024 06:51
@battermann battermann marked this pull request as ready for review October 9, 2024 13:36
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is probably ready, but as always before i'll admit that i have questions :-)

approving tentatively!

@fisx
Copy link
Contributor

fisx commented Oct 9, 2024

oh, one more (very open, sorry) question: there are requests in both directions, but if i am reading this right you've only versioned upstream. this may be fine, though, as lh-to-wire doesn't have any changes between v0 and v1 (yet)? but this thought may guide some renamings like the one mentioned above. or thinking this through may suggest some small refactorings to save us time in the future?

@fisx
Copy link
Contributor

fisx commented Oct 10, 2024

oh, one more (very open, sorry) question: there are requests in both directions, but if i am reading this right you've only versioned upstream. this may be fine, though, as lh-to-wire doesn't have any changes between v0 and v1 (yet)? but this thought may guide some renamings like the one mentioned above. or thinking this through may suggest some small refactorings to save us time in the future?

answer after phone call: lh api only goes upstream. if lh devices use client api, and if lh service wants to call wire-server for anything else, it should use galley public api (or possibly internal, but hopefully not).

@battermann battermann merged commit bd5694c into develop Oct 10, 2024
10 checks passed
@battermann battermann deleted the WPB-11188-adopt-legal-hold-api-v-1 branch October 10, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants