-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPB-11188] LegalHold support V1 #4284
Conversation
b13e00a
to
6ad53de
Compare
d49b259
to
3f0b4a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is probably ready, but as always before i'll admit that i have questions :-)
approving tentatively!
oh, one more (very open, sorry) question: there are requests in both directions, but if i am reading this right you've only versioned upstream. this may be fine, though, as lh-to-wire doesn't have any changes between v0 and v1 (yet)? but this thought may guide some renamings like the one mentioned above. or thinking this through may suggest some small refactorings to save us time in the future? |
answer after phone call: lh api only goes upstream. if lh devices use client api, and if lh service wants to call wire-server for anything else, it should use galley public api (or possibly internal, but hopefully not). |
https://wearezeta.atlassian.net/browse/WPB-11188
Checklist
changelog.d