Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPB-11472] Revert "Work around legacy integration test resource leak. (#4244)" #4287

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Oct 9, 2024

https://wearezeta.atlassian.net/browse/WPB-11472

This reverts commit a72c70a.

it turns out this only helps with resource consumption because after running the first bach of tests, defaultMainWithIngredients exits... m|

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

This reverts commit a72c70a.

(it turns out this only helps with resource consumption because
after running the first bach of tests, defaultMainWithIngredients
exits...  m|
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 9, 2024
@fisx fisx changed the title Revert "Work around legacy integration test resource leak. (#4244)" [WPB-11472] Revert "Work around legacy integration test resource leak. (#4244)" Oct 9, 2024
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. label Oct 9, 2024
@elland elland merged commit 54cdc26 into develop Oct 14, 2024
10 checks passed
@elland elland deleted the fisx/restore-brig-legacy-integration-tests branch October 14, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants