Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPB-685 give SCIM connections human readable names #4307

Merged
merged 21 commits into from
Oct 25, 2024
Merged

WPB-685 give SCIM connections human readable names #4307

merged 21 commits into from
Oct 25, 2024

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Oct 24, 2024 •
edited
Loading

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Oct 24, 2024
@battermann battermann marked this pull request as ready for review October 24, 2024 11:48
@mdimjasevic mdimjasevic force-pushed the WPB-685-give-scim-connections-human-readable-names-in-tm branch from 93fbd76 to e643594 Compare October 24, 2024 12:12
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 24, 2024
mdimjasevic
mdimjasevic approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

fisx
fisx approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now we should do the same thing for saml idps, and then support multiple idps and multiple scim tokens in one team, and connecting them to each other. there should be tickets for that, too, right?

cassandra-schema.cql Show resolved Hide resolved
changelog.d/1-api-changes/WPB-685
@@ -0,0 +1 @@
New variant in API version 7 of endpoints for creating and listing SCIM tokens that support a `name` field. New endpoint in version 7 for updating a SCIM token name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to add it to the changelog in confluence :)

services/spar/src/Spar/Scim/Auth.hs Outdated Show resolved Hide resolved
libs/wire-api/src/Wire/API/Routes/Public/Spar.hs
Comment on lines -210 to -211
type SpecialisedAPIRoutes v SparAPITag = SparAPI
serviceSwagger = toOpenApi (Proxy @SparAPI)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did this go?

@battermann battermann merged commit b0b5a06 into develop Oct 25, 2024
10 checks passed
@battermann battermann deleted the WPB-685-give-scim-connections-human-readable-names-in-tm branch October 25, 2024 09:59
This was referenced Oct 25, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

@mdimjasevic mdimjasevic mdimjasevic approved these changes

Assignees
No one assigned
Labels
echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@battermann @mdimjasevic @fisx @zebot