Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow choosing between argon2id and scrypt as hashing algorithm #4319

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Allow choosing between argon2id and scrypt as hashing algorithm #4319

merged 5 commits into from
Oct 30, 2024

Conversation

akshaymankar
Copy link
Member

https://wearezeta.atlassian.net/browse/WPB-11924

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. label Oct 30, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 30, 2024
@akshaymankar akshaymankar changed the title Allow chosing between argon2id and scrypt as hashing algorithm Allow choosing between argon2id and scrypt as hashing algorithm Oct 30, 2024
fisx
fisx approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please ignore my comments! :)

docs/src/developer/reference/config-options.md Outdated Show resolved Hide resolved
docs/src/developer/reference/config-options.md Show resolved Hide resolved
@akshaymankar @fisx
Fix typo.
56ab857 
Co-authored-by: Matthias Fischmann <[email protected]>
@akshaymankar akshaymankar merged commit d315597 into develop Oct 30, 2024
10 checks passed
@akshaymankar akshaymankar deleted the choose-password-hashing-algo branch October 30, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

Assignees
No one assigned
Labels
echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaymankar @fisx @zebot