Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle auto login when landing on auth pages [WPB-15071] #18655

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: handle auto login when landing on auth pages [WPB-15071] #18655

wants to merge 1 commit into from
+32 −3

Conversation

e-maad
Copy link
Contributor

@e-maad e-maad commented Jan 23, 2025 •
edited by github-actions bot
Loading

BugWPB-15071 [Web] Redirection of Netnod production

Description

Handled auto login when the user has active session and lands on auth pages.
Note: Keeping it behind FF.

Screenshots/Screencast (for UI changes)

Screen.Recording.2025-01-24.at.00.12.53.mov

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@e-maad e-maad requested review from otto-the-bot and a team as code owners January 23, 2025 19:15
@echoes-hq echoes-hq bot added the echoes: unplanned/support Work items completed to meet a customer or user support request. label Jan 23, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

dariaoldenburg
dariaoldenburg reviewed Jan 23, 2025
View reviewed changes
src/script/auth/page/Index.tsx
bindActionCreators(
{
doInit: actionRoot.authAction.doInit,
doInitializeClient: actionRoot.clientAction.doInitializeClient,
Copy link
Contributor

@dariaoldenburg dariaoldenburg Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, is it used? :)

dariaoldenburg
dariaoldenburg reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@dariaoldenburg dariaoldenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, did you ask the designer if it's a good UX for this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariaoldenburg dariaoldenburg dariaoldenburg left review comments

@olafsulich olafsulich olafsulich approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
echoes: unplanned/support Work items completed to meet a customer or user support request. 👕 size: S type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e-maad @dariaoldenburg @olafsulich @otto-the-bot