-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min_request_interval to WBE2-I-EBUS template #832
Conversation
Boiler's controller is not designed for fast polling. Limit requests to it by setting min_request_interval=1000
WalkthroughThe changes in this pull request involve updates to the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
templates/config-wbe2-i-ebus.json (1)
8-8
: Consider adding a comment to document the min_request_interval parameter.While the parameter name is self-explanatory, it would be helpful to add a JSON comment or update the documentation to explain:
- The purpose of this parameter (preventing rapid polling)
- The unit of measurement (milliseconds)
- The recommended range of values
Would you like me to help draft the documentation for this parameter?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
debian/changelog
(1 hunks)templates/config-wbe2-i-ebus.json
(1 hunks)
🔇 Additional comments (2)
templates/config-wbe2-i-ebus.json (1)
8-8
: LGTM! The min_request_interval addition looks good.
The addition of min_request_interval: 1000
is well-placed at the device level and will effectively prevent rapid polling of the boiler controller. The 1-second interval is a reasonable default that balances responsiveness with controller stability.
debian/changelog (1)
1-5
: Changelog entry matches PR objectives
The changelog entry correctly documents:
- The addition of min_request_interval=1000 to WBE2-I-EBUS template
- Version increment from 2.147.0 to 2.147.1
- Proper maintainer information and date
…OFT-4615-ebus-template
Boiler's controller is not designed for fast polling. Limit requests to it by setting min_request_interval=1000
В инструкции по подключению модуля указано использование устаревшей настройки wb-mqtt-serial. Она нужна для ограничения числа запросов к бойлеру. Заменим эту настройку на актуальную
Summary by CodeRabbit
New Features
Improvements
press_counter
register values are stored immediately, preventing outdated data publication after unexpected service restarts.