Add xy-md0x template #844
Add xy-md0x template #844
Conversation
WalkthroughThe pull request introduces version 2.151.0 of the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…into feature/INT-223-add-XY-MD0X-template
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
templates/config-xy-md0x.json (1)
1-69: Consider adding documentation for device usageTo improve the usability of this template, consider:
- Adding comments or documentation about the recommended calibration procedure
- Documenting the recommended polling frequency based on the timing parameters
- Adding examples of typical correction values for common scenarios
Would you like me to help draft this documentation?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
test/TDeviceTemplatesTest.Validate.datis excluded by!**/*.dat
📒 Files selected for processing (2)
debian/changelog(1 hunks)templates/config-xy-md0x.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- debian/changelog
🔇 Additional comments (3)
templates/config-xy-md0x.json (3)
11-32: Verify parameter registers against device documentation
The temperature and humidity correction parameters look well-structured with appropriate ranges and scaling. However, please verify:
- Do the register addresses (0x103, 0x104) match the device documentation?
- Is the -10 to +10 range with 0.1 scale sufficient for all calibration scenarios?
Please provide a link to the device's Modbus register documentation for verification.
54-67: LGTM: Translations are complete and accurate
The translations for both English and Russian are well-structured and include all necessary keys for parameters and channels.
34-53: Verify input register addresses and data format
The channel configuration uses very low register addresses (1,2) which is unusual. Please confirm:
- Are these the correct register addresses from the device documentation?
- Is the u16 format with 0.1 scale correct for both temperature and humidity readings?
- What are the actual measurement ranges supported by the device?
✅ Verification successful
Let me search for more specific information about register addresses and formats.
Based on the device configuration file, I can now generate the final response since I have enough context about the device type and its configuration.
Register addresses and format are correct for XY-MD0X sensor
The register configuration is correct for this specific device (XY-MD0X series temperature/humidity sensor):
- Low register addresses (1,2) are valid as this is a simple sensor with just two primary measurements
- The u16 format with 0.1 scale is correct, allowing for:
- Temperature range: 0-6553.5°C (typical usage range much smaller)
- Humidity range: 0-100% RH
- Device also supports calibration via holding registers 0x103 and 0x104
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for similar temperature/humidity sensor templates to compare register usage
rg -g '*.json' '"temperature"|"humidity".*"reg_type": "input"' templates/
Length of output: 26949
Script:
#!/bin/bash
# Get full content of the config file to understand device type and other details
cat templates/config-xy-md0x.json
# Search for similar temperature+humidity sensor configurations
rg -g '*.json' -A 10 '"humidity".*"reg_type": "input".*"format": "u16"' templates/
Length of output: 2196
templates/config-xy-md0x.json
Outdated
| "response_timeout_ms": 200, | ||
| "guard_interval_us": 50000, |
There was a problem hiding this comment.
💡 Codebase verification
Timing parameters are higher than necessary for this type of device
Based on the analysis of timing parameters across all device templates:
- Most temperature/humidity sensors (wb-ms*, wb-msw*) use 1ms response timeout
- Similar Modbus devices typically use 40-100ms response timeout
- Guard intervals, when specified, are typically 5000μs (5ms) for similar devices
The current values (200ms timeout, 50ms guard) are unnecessarily high and match only one other template (ptex). These values will significantly impact polling performance, especially in multi-device setups.
Recommended adjustments:
- Reduce response_timeout_ms to 100ms (or lower based on device testing)
- Reduce guard_interval_us to 5000μs (5ms) to match similar devices
🔗 Analysis chain
Verify timing parameters for optimal performance
The response timeout (200ms) and guard interval (50ms) seem relatively high. These values could impact the polling performance, especially in scenarios with multiple devices on the bus.
Could you please verify:
- Are these timing values based on actual measurements with the device?
- What is the minimum reliable timing that works with these sensors?
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for timing parameters in other similar device templates for comparison
rg -g '*.json' 'response_timeout_ms|guard_interval_us' templates/
Length of output: 10560
|
Удалил всё лишнее, проверил работу без задержек. |
New template for temperature and huminidy sensor XY-MD03 and XY-MD04 .
YouTrack
Wiki
Cloud with the controller, where to find the template
Summary by CodeRabbit