Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for units to wire lengths. Part 2 #162

Closed
wants to merge 1 commit into from
Closed

Add support for units to wire lengths. Part 2 #162

wants to merge 1 commit into from

Conversation

zombielinux
Copy link
Contributor

Will also be editing harness.py to add the support as well as defaulting units to meters if unpopulated.

@zombielinux
Add support for units to wire lengths. Part 2
67a25e3 
Will also be editing harness.py to add the support as well as defaulting units to meters if unpopulated.
stevegt added a commit to stevegt/WireViz that referenced this pull request Oct 5, 2020
@stevegt
add length_unit
32cb73b 
- partial fix for wireviz#7
- based on and closes wireviz#161 and wireviz#162
This was referenced Oct 5, 2020
Closed
Closed
kvid pushed a commit to kvid/WireViz that referenced this pull request Oct 5, 2020
@stevegt @kvid
add length_unit
dd50619 
- partial fix for wireviz#7
- based on and closes wireviz#161 and wireviz#162
kvid pushed a commit to kvid/WireViz that referenced this pull request Oct 5, 2020
@stevegt @kvid
add length_unit
05456b4 
- partial fix for wireviz#7
- based on and closes wireviz#161 and wireviz#162
kvid pushed a commit to kvid/WireViz that referenced this pull request Nov 15, 2020
@stevegt @kvid
Add length_unit
e1ea1f1 
- partial fix for wireviz#7
- based on and closes wireviz#161 and wireviz#162
kvid pushed a commit to kvid/WireViz that referenced this pull request Nov 16, 2020
@stevegt @kvid
Add length_unit
8cd3e2d 
- partial fix for wireviz#7
- based on and closes wireviz#161 and wireviz#162
@kvid kvid mentioned this pull request Nov 16, 2020
Merged
17o2 pushed a commit that referenced this pull request Nov 16, 2020
@zombielinux @stevegt
@kvid @17o2
Add support for wire length units
dec64ab 
Based on #161, #162, #171.

Co-authored-by: stevegt <[email protected]>
Co-authored-by: kvid <[email protected]>
@17o2
Copy link
Collaborator

17o2 commented Nov 16, 2020

Closed as part of #196.

@17o2 17o2 closed this Nov 16, 2020
17o2 added a commit that referenced this pull request Nov 16, 2020
@17o2
Add #7, #196 (#161, #162, #171)
4fd8b1f
17o2 pushed a commit that referenced this pull request Nov 17, 2020
@kvid @stevegt
Add support for wire length units
3c205fe 
Based on #161, #162, #171.

Co-authored-by: stevegt <[email protected]>
Co-authored-by: kvid <[email protected]>
@joezappie
Copy link

Is this merged into the version published to pip? Im trying to change my lengths to inches as meters seems odd for an 8 inch cable but using length_unit gives me error: " got an unexpected keyword argument 'length_unit'"

@17o2
Copy link
Collaborator

17o2 commented Oct 5, 2021 •
edited
Loading

Sorry, pip is currently at v0.2.
If you need this feature, please use the dev branch (v0.3-dev), then you can simply use length: 8 in.
You can use any unit you want, but keep in mind that no conversion is done (so inches and feet will not be added up in the BOM) and that you need a space between the number and the unit. length: 8 " is also supported, provided you leave the space.

See the syntax description for more info, and the changelog* to see what other features you get in v0.3-dev.

* Currently, the changelog is maintained in the doc/changelog branch, so the dev branch's changelog will not be up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zombielinux @17o2 @joezappie