OFF-1457 #7
Closed
OFF-1457 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-lei
reviewed
Sep 18, 2024
adapters/flipp/flipp.go
Outdated
| customDataInterface := decision.Contents[0].Data.CustomData | ||
| customDataMap, ok := customDataInterface.(map[string]interface{}) | ||
| var defaultStandardHeight int64 = 2400 | ||
| var defaultCompactHeight int64 = 600 |
There was a problem hiding this comment.
We should use const for constants and place them at the beginning of the file
hasan-kanjee
requested changes
Sep 18, 2024
adapters/flipp/flipp.go
Outdated
Comment on lines
224
to
225
| var defaultStandardHeight int64 = 2400 | ||
| var defaultCompactHeight int64 = 600 |
There was a problem hiding this comment.
should move this to the top of the file with all the other consts
adapters/flipp/flipp.go
Outdated
Comment on lines
227
to
248
| if flippExtParams.Options.StartCompact { | ||
| if ok { // check if customDataMap exists and startCompact is true | ||
| if height, exists := customDataMap["compactHeight"].(int64); exists { | ||
| bid.H = height | ||
| } else { | ||
| bid.H = defaultCompactHeight | ||
| } | ||
| } else { | ||
| bid.H = defaultCompactHeight | ||
| } | ||
| } else { // startCompact is false | ||
| if ok { // customDataMap exists | ||
| if height, exists := customDataMap["standardHeight"].(int64); exists { | ||
| bid.H = height | ||
| } else { | ||
| bid.H = defaultStandardHeight | ||
| } | ||
| } else { | ||
| bid.H = defaultStandardHeight | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
You can simplify this a little further by doing
if flippExtParams.Options.StartCompact {
defaultHeight = defaultCompactHeight
} else {
defaultHeight = defaultStandardHeight
}
bid.H = defaultHeight
if ok {
if height, exists := customDataMap[flippExtParams.Options.StartCompact ? "compactHeight" : "standardHeight"].(int64); exists {
bid.H = height
}
}There was a problem hiding this comment.
if height, exists := customDataMap[flippExtParams.Options.StartCompact ? "compactHeight" : "standardHeight"].(int64); exists {
I get an error for the ? operator, saying expected ']', found 'ILLEGAL'syntax
There was a problem hiding this comment.
Sorry 🤦♂️ you can do this instead
if flippExtParams.Options.StartCompact {
defaultHeight = 600 // Default compact height
} else {
defaultHeight = 2400 // Default standard height
}
// Set default height first
bid.H = defaultHeight
if ok { // customDataMap exists
var key string
if flippExtParams.Options.StartCompact {
key = "compactHeight"
} else {
key = "standardHeight"
}
if height, exists := customDataMap[key].(int64); exists {
bid.H = height
}
}
hasan-kanjee
force-pushed
the
master
branch
from
48710ca to
905b3a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.