Skip to content

Commit

Permalink
fix: don't log warning if i18nDomains isn't enabled (#9932)
Browse files Browse the repository at this point in the history
* fix: don't log warning if  isn't enabled

* fix regression

---------

Co-authored-by: Arsh <[email protected]>
  • Loading branch information
ematipico and lilnasy authored Feb 2, 2024
1 parent 4ee2729 commit 9f0d89f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/mean-pugs-nail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"astro": patch
---

Fixes a case where a warning was logged even when the feature `i18nDomains` wasn't enabled
2 changes: 1 addition & 1 deletion packages/astro/src/integrations/astroFeaturesValidation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export function validateSupportedFeatures(
);
validationResult.assets = validateAssetsFeature(assets, adapterName, config, logger);

if (i18nDomains) {
if (i18nDomains && config?.experimental?.i18nDomains === true && !config.i18n?.domains) {
validationResult.i18nDomains = validateSupportKind(
i18nDomains,
adapterName,
Expand Down

0 comments on commit 9f0d89f

Please sign in to comment.