Regression: getViteConfig doesn't work after 4.9.3 release

[vchirikov]

Astro Info

4.9.2 - works
4.9.3+ (tested on 4.10.1) doesn't

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

Regression: getViteConfig is broken after 4.9.3+ (including the latest 4.10.1) and doesn't return the correct config to vitest.

In the gif I showed that the regression:

getViteConfig works fine (it returns correct environment to vitest) and doesn't work at 4.10.1
(ReferenceError: document is not defined shows us that vitest's environment is not defined, I also re-checked this with // @vitest-environment happy-dom)

the vitest.config.ts:

/// <reference types="vitest" />

import { getViteConfig } from 'astro/config';

export default getViteConfig({
  test: {
    testTimeout: 10_000,
    css: false,
    globals: false,
    environment: 'happy-dom',
    include: ['./tests/**/*.test.{ts,tsx}'],
    setupFiles: [
      '@testing-library/react/dont-cleanup-after-each',
      './tests/vitest.setup.ts'
    ],
    pool: 'threads',
    poolOptions: {
      threads: {
        isolate: false,
        minThreads: 4,
      }
    },
    isolate: false,
    typecheck: {
      enabled: true,
      tsconfig: 'tsconfig.json',
    }
  },
}, {
  site: 'http://localhost:3000/base',
},
);

Repro

https://github.com/vchirikov/astro_issue_11221

What's the expected result?

getViteConfig returns the correct config with defined environment

[vchirikov]

Related issues & PRs:

#11175
#11194

[github-actions]

Hello @vchirikov. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with needs repro will be closed if they have no activity within 3 days.

[vchirikov]

@ematipico added repository with repro - https://github.com/vchirikov/astro_issue_11221

[Baztoune]

I'm not 100% sure the issue I encountered is the exact same, but it looks related. The vite config seems ignored, at least the include and exclude properties.
I started a minimal reproduction from the officiel with-vitest example on stackblitz

• astro 4.9.3 https://stackblitz.com/edit/github-rtr3kz-pt5kmn?file=package.json&view=editor
• astro 4.10.1 https://stackblitz.com/edit/github-rtr3kz-p24tcc?file=package.json&view=editor

For this purpose, I defined a include config with specific **/*.omg.ts glob pattern and renamed the test file as basic.omg.ts.
npm install && npm run test runs tests in 4.9.3 ✅ , but ignores it in 4.10.1 ❌ . Could it be linked to #11194 ?

Please tell me if you need more info, or if I missed something.

[Baztoune]

As a side note, passing my config as the 2nd arg gives me the expected result, but I don't think this is intended. According to #11194 only inlineConfig.root is used, so other properties might just be ignored ?

// this actually uses the test config
export default getViteConfig(
  {},
  {
    vite: {
      test: {
        include: ['**/*.omg.ts'],
      },
    },
  }
);

[vchirikov]

Yep, but according the docs we should use the first arg. For now I use the same workaround:

import { getViteConfig, type ViteUserConfig } from 'astro/config';

// ...
const config = {
  test: { /* the actual vitest config*/} 
} satisfies { test: ViteUserConfig['test']; };

export default getViteConfig(
  { ...config },
  { vite: { ...config }},
);

[Baztoune]

Yep, but according the docs we should use the first arg.

Absolutely, I just wanted to emphase that the 2 args got mixed up in the quoted PR