-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running Vite server during build breaks plugin assumptions #6364
Comments
It is not heuristic, since Astro is using Vite from api, any configured plugin will run. Running Vite cli will filter plugins: Checking the code in Astro PWA repo to allow pwa run without any problem, it seems we also had also a problem with |
Maybe I can include a protection using command on configResolved hook in main plugin |
I believe @bholmesdev plans to get rid of the special temporary Vite server and just load through the normal one. |
What version of
astro
are you using?2.0.12+
Are you using an SSR adapter? If so, which one?
N/A
What package manager are you using?
pnpm
What operating system are you using?
macOS
Describe the Bug
In #6238, we broke
vite-plugin-pwa
(and possibly others) because we started running a temporary Vite server during the build to load Content Collections.vite-plugin-pwa
usesapply: 'serve'
as a heuristic for running the dev server, which no longer works when we start a temporary server and pass all plugins to that server.cc @userquin
Link to Minimal Reproducible Example
https://stackblitz.com/edit/github-kyecnu?file=integration.js,astro.config.mjs,package.json
Participation
The text was updated successfully, but these errors were encountered: