Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example(pwa): use @vite-pwa/astro integration #6362

Closed
wants to merge 6 commits into from
Closed

example(pwa): use @vite-pwa/astro integration #6362

wants to merge 6 commits into from

Conversation

userquin
Copy link
Contributor

Changes

  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can help as well.
  • Don't forget a changeset! pnpm exec changeset

check title

Testing

None

Docs

None

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a487022

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@userquin userquin marked this pull request as draft February 24, 2023 20:32
@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Feb 24, 2023
@natemoo-re
Copy link
Member

Related to #6364

@userquin userquin marked this pull request as ready for review February 27, 2023 21:53
@userquin userquin marked this pull request as draft February 28, 2023 11:31
userquin added 2 commits March 3, 2023 22:41
@userquin
Merge branch 'main' into feat-update-pwa-example
c2e9dfe 
# Conflicts:
#	examples/with-vite-plugin-pwa/package.json
#	pnpm-lock.yaml
@userquin
chore: update deps and example
a487022
@userquin userquin marked this pull request as ready for review March 3, 2023 22:19
@matthewp
Copy link
Contributor

matthewp commented Mar 7, 2023

This PR is stale. If you're still interested, open a new PR and be sure to fill out the form sections.

@matthewp matthewp closed this Mar 7, 2023
@userquin
Copy link
Contributor Author

userquin commented Mar 7, 2023

@matthewp why are you closing this PR?. The PR was ready last thursday or friday, I haven't had time to update it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@userquin @natemoo-re @matthewp