Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue where certain characters break redirects in SSR #10411

Closed
wants to merge 2 commits into from
Closed

Fix an issue where certain characters break redirects in SSR #10411

wants to merge 2 commits into from

Conversation

mingjunlu
Copy link
Contributor

@mingjunlu mingjunlu commented Mar 13, 2024 •
edited
Loading

Changes

Testing

  • A test case is added
  • Current tests should pass

Docs

  • N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: b6ccabf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 13, 2024
@mingjunlu
Copy link
Contributor Author

Duplicate of #10410

@mingjunlu mingjunlu closed this Mar 13, 2024
@lilnasy
Copy link
Contributor

lilnasy commented Mar 13, 2024

@mingjunlu Great work! I have cherry-picked the production test over to 10410.

@lilnasy lilnasy mentioned this pull request Mar 13, 2024
Merged
@mingjunlu
Copy link
Contributor Author

@lilnasy Much appreciated! That's very kind of you 😊

@mingjunlu mingjunlu deleted the fix/special-characters-break-ssr-redirects branch March 13, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirects crash in SSR with certain characters in URL
2 participants
@mingjunlu @lilnasy