🐛 removed deprecated items from lit integration #11164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 034e325 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: lit
1 task
Merged
jrencz
reviewed
May 29, 2024
Comment on lines
-10
to
+11
| const polyfillCheckEl = new DOMParser() | ||
| .parseFromString( | ||
| `<p><template shadowroot="open" shadowrootmode="open"></template></p>`, | ||
| 'text/html', | ||
| { | ||
| includeShadowRoots: true, | ||
| } | ||
| ) | ||
| const polyfillCheckEl = Document | ||
| .parseHTMLUnsafe(`<p><template shadowrootmode="open"></template></p>`) |
There was a problem hiding this comment.
Hi,
May I ask about the compatibility?
parseFromString is there in basically every browser (https://developer.mozilla.org/en-US/docs/Web/API/DOMParser/parseFromString) while parseHTMLUnsafe is not yet well supported (https://caniuse.com/mdn-api_document_parsehtmlunsafe_static today reports global of just under 58%)
Won't that be a problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Deprecated API
Chrome's deprecation info:
https://chromestatus.com/feature/5116094370283520
Related story:
#11160
Deprecated Attribute
shadowrootattribute which was deprecated by chrome and not needed by other browsersDeprecation info:
https://chromestatus.com/feature/6239658726391808
Testing
The original file did not include tests so I installed
client-shimand client-shim-minlocally and tested them with the latest astro install I have, which haslit` components in itDocs
Should not change the user experience. Worked for me with both local dev server and build/preview