Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routing): multiple decoding #12927

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix(routing): multiple decoding #12927

merged 1 commit into from
Jan 8, 2025

Conversation

ematipico
Copy link
Member

Changes

Closes PLT-2724
Closes #12847

There are two issues:

  • we decoded the pathname multiple times
  • we didn't decode the pathname early in all the pipelines

I tracked down the issue and fixed, I also added some comments to help developers with the code.

Testing

Added a new test to cover the issue that we fixed

Docs

N/A

Unverified

This user has not yet uploaded their public signing key.
Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: 35dea48

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 8, 2025
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #12927 will not alter performance

Comparing fix/multiple-decoding (35dea48) with main (8b9d530)

Summary

✅ 6 untouched benchmarks

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change a lot! Decoding as soon as we retrieve an encoded URL makes it a lot more consistent internally.

@ematipico ematipico merged commit ad2a752 into main Jan 8, 2025
16 checks passed
@ematipico ematipico deleted the fix/multiple-decoding branch January 8, 2025 11:55
@astrobot-houston astrobot-houston mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Percent sign in getStaticPaths params breaks astro build, throws a URI malformed error.
2 participants