Fixes #251 closing the parent tag if the component rendering led to a… #283

ewatch · 2021-05-31T14:27:15Z

If a component is not rendered because it doesn't exist the codegen still adds a closing parenthesis to the render function and therefore closes the last parent Element.

Changes

Adds additional marker for the code generator to know if a component was rendered and therefore isn't accidently closing the parent tag if not.

Testing

Tests are passing
should fix the test of issue test: add test for missing component, unknown component #251

…n error

changeset-bot · 2021-05-31T14:27:17Z

⚠️ No Changeset found

Latest commit: 00afc6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

* Add benchmarking for the dev server This adds benchmarking for the dev server. * Use fs.rm instead * Only rimraf if the folder exists * Make uncached match CI * Change the cached time too * Don't run benchmark in CI * Switch back test command * Make tests be within 10 percent * Use yarn to run multiple things * Turn benchmark into uvu tests * Debugging benchmark * Print chunk for testing * Ignore benchmark folder in uvu * Add build benchmarking * Update benchmark numbers

* documentation: post #231 merge renderers are a config option * Update docs/config.md to reorder

* refactor: pluggable renderers * refactor: cache renderer per component * docs: update comments on snowpack plugin `transform` method * docs: add comments to renderer plugins * refactor: convert components to Map * fix: pass children through to astro __render * refactor: move Components/ComponentInfo to shared types * refactor: remove `gatherRuntimes` step, just scan output for imports * refactor: update isComponentTag logic * chore: move dependencies to renderers * fix: cross-platform transform injection * feat: defer renderer to react, fallback to preact * fix: use double quotes in generated script * test: fix failing children tests * test: add workspaceRoot to all tests * fix: pass props to renderer check * chore: add test:core script back for convenience * chore: remove unused external * chore: rename renderers * chore: add astring, estree-util-value-to-estree * chore: render-component => __astro_component * refactor: split hydrate logic to own file * refactor: use `astro-fragment` rather than `div` * chore: remove unused hooks * chore: delete unused file * chore: add changesets * fix: Astro renderer should be async * fix: remove <astro-fragment> for static content * test: fix failing test * chore: normalize config interface * feat: allow renderers to inject a snowpackPlugin * fix: resolve import URL before using dynamic import * refactor: update renderers to use separate /server entrypoint * refactor: update server renderer interface * fix: get renderers working again * test: debug failing test * test: better debug * test: better debug * test: remove debug * fix: support esm and cjs packages via "resolve" * refactor: split hydrate functions into individual files * fix: dependency resolution relative to projectRoot * fix: @snowpack/plugin-postcss needs to be hoisted * fix: do not test prettier-plugin-astro as it's not ready for primetime

* chore: update getting started config #245 * chore: reorder renderers

* fix: remove remote urls from import scanner * debug test

Fixes #183

* fix: markdown issues * wip: add docs example * example: update doc template * chore: credit Steph for AvatarList * chore: align footer to bottom viewport * chore: feeback R1 * fix: font fallback in firefox * fix merge conflicts * fix: add default value to headers * chore: fix doc example

* feat: enable HMR in `createSnowpack` * feat: enable Snowpack's HMR * chore: add changeset * chore: remove unused file * chore: add changeset

* Fix codeblocks in markdown components * Debugging * More debugging * remove extra debugging stuff

* chore: release vscode * chore: move astro-languageserver deps to devDeps * chore: enter pre

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: add package.json to externals * fix: add missing packages to allowList * fix: temporarily disable @astrojs/renderer-vue * chore: add changeset

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…n error

…https://github.com/snowpackjs/astro into fix/closing-parent-tag-if-component-was-not-rendered

natemoo-re · 2021-06-01T21:59:18Z

packages/astro/src/compiler/codegen/index.ts

@@ -572,6 +573,7 @@ async function compileHtml(enterNode: TemplateNode, state: CodegenState, compile
              paren++;
              buffers[curr] += `h(${wrapper}, ${attributes ? generateAttributes(attributes) : 'null'}`;
            } catch (err) {
+              state.markers.componentWasNotRendered = true;


Instead of adding a new marker, could you just use paren--? That should effectively do the same thing. paren is there to mark how many open parentheses need to be closed.

matthewp · 2021-06-02T17:22:41Z

Rebasing with main should have the tests passing.

matthewp · 2021-06-04T18:19:47Z

@ewatch no rush or anything, just a reminder that this should be good after a rebase.

ewatch · 2021-06-06T17:47:54Z

Sure will take care of it. Thank you for the reminder @matthewp.
Thanks for the idea @natemoo-re. I will change it that way.

FredKSchott · 2021-06-13T20:10:05Z

@ewatch friendly bump!

ewatch · 2021-06-15T11:52:55Z

Yeah I messed up my local branch. :-(
I will create a second branch with the small adaption, hope that's fine. And then we can close this.

ewatch · 2021-06-17T21:32:20Z

see PR #490

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

duncanhealy and others added 3 commits May 26, 2021 13:41

test: add test for missing component, unknown component

6876bc8

test: seperate test for different errors

4b224ab

Fixes #251 closing the parent tag if the component rendering led to a…

fd5b2f4

…n error

ewatch changed the base branch from main to test/add-non-existant-import May 31, 2021 14:29

ewatch changed the base branch from test/add-non-existant-import to main May 31, 2021 14:30

matthewp and others added 24 commits May 31, 2021 17:49

[ci] yarn format

f4cd3b8

fix: package for templates to latest version of astro #245 (#248)

5f7a633

documentation: post #231 merge renderers are a config option (#249)

f2f98cf

* documentation: post #231 merge renderers are a config option * Update docs/config.md to reorder

[ci] yarn format

d5e230f

[ci] yarn format

1ea54a3

chore: update getting started config #245 (#250)

9b5a5f4

* chore: update getting started config #245 * chore: reorder renderers

Remove remote urls from import scanner (#256)

d5f8109

* fix: remove remote urls from import scanner * debug test

Fix npm init astro for npm v7 (#257)

0371f61

Fixes #183

chore: release [email protected]

7b610f5

TEMP: remove react from create-astro deps

dfb5b57

TEMP: skip create-astro tests

4a0e04b

chore: cleanup deps (#261)

51d87cc

chore: update lockfile

1017af7

[ci] yarn format

7b41005

Enable HMR (#260)

9cbca61

* feat: enable HMR in `createSnowpack` * feat: enable Snowpack's HMR * chore: add changeset * chore: remove unused file * chore: add changeset

[ci] yarn format

af83e8e

Fix codeblocks in markdown components (#264)

1dd71c5

* Fix codeblocks in markdown components * Debugging * More debugging * remove extra debugging stuff

[ci] yarn format

cda06fa

Make UVU tests time out (#265)

f7cc6a7

Bugfix: CLI selected item spacing (#259)

efbe7b1

Improve Advanced Styling doc (#268)

ab53bd9

natemoo-re and others added 15 commits May 31, 2021 17:49

[ci] yarn format

54bd89f

Enter prerelease (#278)

489e9e1

* chore: release vscode * chore: move astro-languageserver deps to devDeps * chore: enter pre

[ci] yarn format

9fc7799

Version Packages (next) (#227)

261b403

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[ci] yarn format

c227c6f

chore: update astro-parser

f330c08

chore: bump lockfile

e49c0bc

[ci] yarn format

5d1834d

chore: release [email protected]

4700239

Temporarily disable @astrojs/renderer-vue (#279)

9a50613

* chore: add package.json to externals * fix: add missing packages to allowList * fix: temporarily disable @astrojs/renderer-vue * chore: add changeset

Version Packages (next) (#280)

072d810

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[ci] yarn format

7f0ecf5

Fixes #251 closing the parent tag if the component rendering led to a…

d5d68ca

…n error

Merge branch 'fix/closing-parent-tag-if-component-was-not-rendered' of …

dc6c60e

…https://github.com/snowpackjs/astro into fix/closing-parent-tag-if-component-was-not-rendered

state needs to be reset after component which was not rendered

00afc6c

natemoo-re reviewed Jun 1, 2021

View reviewed changes

ewatch requested a review from a team as a code owner June 13, 2021 22:18

github-actions bot force-pushed the main branch from 3bb9ae8 to b49ca27 Compare June 14, 2021 19:47

ewatch closed this Jun 17, 2021

natemoo-re deleted the fix/closing-parent-tag-if-component-was-not-rendered branch June 17, 2021 22:19

snyk-io bot mentioned this pull request May 22, 2024

[Snyk] Upgrade nanostores from 0.9.5 to 0.10.3 Hawthorne001/astro#5

Open

ematipico pushed a commit that referenced this pull request Feb 6, 2025

chore(deps): update node.js to v20 (#283)

82daa76

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #251 closing the parent tag if the component rendering led to a… #283

Fixes #251 closing the parent tag if the component rendering led to a… #283

ewatch commented May 31, 2021 •

edited

Loading

changeset-bot bot commented May 31, 2021 •

edited

Loading

natemoo-re Jun 1, 2021

matthewp commented Jun 2, 2021

matthewp commented Jun 4, 2021

ewatch commented Jun 6, 2021

FredKSchott commented Jun 13, 2021

ewatch commented Jun 15, 2021

ewatch commented Jun 17, 2021

Fixes #251 closing the parent tag if the component rendering led to a… #283

Fixes #251 closing the parent tag if the component rendering led to a… #283

Conversation

ewatch commented May 31, 2021 • edited Loading

Changes

Testing

changeset-bot bot commented May 31, 2021 • edited Loading

⚠️ No Changeset found

natemoo-re Jun 1, 2021

Choose a reason for hiding this comment

matthewp commented Jun 2, 2021

matthewp commented Jun 4, 2021

ewatch commented Jun 6, 2021

FredKSchott commented Jun 13, 2021

ewatch commented Jun 15, 2021

ewatch commented Jun 17, 2021

ewatch commented May 31, 2021 •

edited

Loading

changeset-bot bot commented May 31, 2021 •

edited

Loading