Exclude any ?raw or ?url css imports when adding asset links #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4eb9911 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
tony-sull
changed the title
tony-sull
force-pushed
the
fix/css-raw-imports
branch
from
b286b60 to
de0b7af
Compare
tony-sull
changed the title
tony-sull
force-pushed
the
fix/css-raw-imports
branch
from
d8b8507 to
4eb9911
Compare
This was referenced Apr 7, 2022
Merged
Closed
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
…ro#3020) * exclude any ?raw css imports when adding css asset links * ?url imports should be ignored as well * chore: adding changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updating
astro buildto match the behavior inastro dev- any CSS files imported as?rawor?urlwill be skipped when linking to final bundled assetsThis matches Vite behavior where these imports aren't included in the internal asset graph(s) or in
assetsIncludeTesting
Added a test to verify a page that uses both normal ESM imports,
?raw, and?urlimportsDocs
Related docs PR #326