Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes adding set-cookie headers multiple times #3026

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Apr 7, 2022

Changes

  • Fixes 🐛 BUG: Unable to set multiple cookies #3024
  • Turns out the fetch standard doesn't provide a way to get multiple of the same header. Even though you can .append() them, you can't read out each value.
  • Luckily node-fetch has a workaround, which is being used here.

Testing

Test added

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2022

🦋 Changeset detected

Latest commit: b6eb523

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Apr 7, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

That's an interesting api design for the fetch spec

@matthewp matthewp merged commit 4b0f27d into main Apr 7, 2022
@matthewp matthewp deleted the multiple-same-header branch April 7, 2022 19:18
This was referenced Apr 7, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Fixes adding set-cookie headers multiple times

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Unable to set multiple cookies
2 participants