Perf: reuse Shiki highlighters per theme/lang #3130
Conversation
🦋 Changeset detectedLatest commit: 0f023d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
| // Highlighter has already been requested, reuse the same instance | ||
| if (_resolvedHighlighters.has(key)) { return _resolvedHighlighters.get(key) } | ||
|
|
||
| // Start the async getHighlighter call and cache the Promise |
There was a problem hiding this comment.
Did a bit more poking around and confirmed that this looks like the memory issue was just due to pages being built in parallel. Each page initialized a highlighter and Node couldn't garbage collect them in between page builds
Caching the promise here makes sure that each page gets an immediate response and they can all share the same highlighter instance
There was a problem hiding this comment.
ah nice, we had to do this in the remark plugin also, wish we could reuse more logic between teh two!
* reuse Shiki highlighters per theme/lang * chore: adding changeset
Changes
Fixes #3110
This updates the built-in
<Code>component to reuse Shiki highlighters based on thethemeandlangpropertiesTesting
Tested locally against the astro-imagetools docs site
Before
Error: fail to memory allocationAfter
Docs
N/A