Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix create-astro template issue #334

Merged
merged 1 commit into from
Jun 8, 2021
Merged

fix create-astro template issue #334

merged 1 commit into from
Jun 8, 2021

Conversation

FredKSchott
Copy link
Member

Changes

  • the prompts package fails when it sees an empty option
  • a bad commit added an empty object to the "select template" screen

Testing

  • Not testable since it only happened in interactive mode
  • Tests continue to pass

@FredKSchott FredKSchott requested a review from a team as a code owner June 8, 2021 16:49
@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 5eda844

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthewp matthewp merged commit d6a7349 into main Jun 8, 2021
@matthewp matthewp deleted the create-astro-fix branch June 8, 2021 16:56
@pippaine pippaine mentioned this pull request Feb 4, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FredKSchott @matthewp