Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update "building for SSR" messaging on SSG #3399

Merged
merged 2 commits into from
May 18, 2022

Conversation

bholmesdev
Copy link
Contributor

Changes

  • A few discord users were confused by the "building for SSR" messaging during SSG. This introduces new messaging:
    • When using SSG: Build entrypoints for prerendering...
    • When using an SSR adapter: Building SSR entrypoints...

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented May 18, 2022

🦋 Changeset detected

Latest commit: f379bd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 18, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A welcome change! LGTM.

@bholmesdev bholmesdev merged commit 1bf1226 into main May 18, 2022
@bholmesdev bholmesdev deleted the cli/building-for-ssr-prod-build-messaging branch May 18, 2022 15:45
@github-actions github-actions bot mentioned this pull request May 18, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* fix: update "building for SSR" messaging on SSG

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants