Fix: Support .html requests in dev #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3258e26 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
tony-sull
force-pushed
the
fix/dev-routing-file-format
branch
from
80b4f6b to
ed0fcce
Compare
matthewp
reviewed
May 18, 2022
| expect(response.status).to.equal(200); | ||
| }); | ||
|
|
||
| it('200 when loading /', async () => { |
There was a problem hiding this comment.
👍 glad to see this test, we should still support not including index.html
There was a problem hiding this comment.
I could have also named this PR "Fun with Regexes" 😄
Merged
1 task
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* WIP: this regex should handle .html as well * much simpler! Just fix the req.url, don't touch the manifest * only handle .html requests when config.build.format === 'file' * chore: add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This updates the dev server to support
.htmlrequests, currently only/blogis matched and/blog.htmlwould 404Testing
Added a test to verify
.htmlis supported in dev whenconfig.build.format === 'file'Docs
None, bug fix only