Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the correct content-type for CSS HMR #3459

Merged
merged 2 commits into from
May 31, 2022
Merged

Set the correct content-type for CSS HMR #3459

merged 2 commits into from
May 31, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented May 27, 2022

Changes

Testing

  • Test added which mimics what Vite does in HMR.

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented May 27, 2022

🦋 Changeset detected

Latest commit: 17bf738

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 27, 2022
@matthewp matthewp marked this pull request as draft May 27, 2022 19:42
@matthewp matthewp force-pushed the fix-firefox-css-hmr branch from 612da37 to 956971e Compare May 27, 2022 19:58
@matthewp matthewp marked this pull request as ready for review May 31, 2022 13:11
@matthewp matthewp force-pushed the fix-firefox-css-hmr branch from 8c71996 to fb48720 Compare May 31, 2022 13:12
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@matthewp matthewp merged commit efccebb into main May 31, 2022
@matthewp matthewp deleted the fix-firefox-css-hmr branch May 31, 2022 15:40
@github-actions github-actions bot mentioned this pull request May 31, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Set the correct content-type for CSS HMR

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: CSS HMR causes flashes 🐛 BUG: DevServer - CSS does not trigger Browser reload on Firefox
3 participants