-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make Remark rehype options available in astro config #4138
Conversation
🦋 Changeset detectedLatest commit: 2f2271d The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@EiffelFly i think this is it! I had to explicitly import the types for handlers and add them back in the RemarkRehype type. I don't think the failing tests are related to this patch so hopefully this is ok. |
Making a note to pull this from the MDX integration! I'll make a separate PR for that when this is merged 👍 |
@bholmesdev, should this work with MDX already? The following config does not overwrite the title for me when using export default defineConfig({
integrations: [
mdx(),
],
markdown: {
remarkRehype: {
footnoteLabel: "Hi Ben",
},
},
});
|
@bholmesdev, I guess we would have to pass Is this something you would want to combine with custom |
@backflip Ah, right you are! I agree this should be applied when |
Changes
Testing
Add this in astro.config.mjs
Create a markdown page with a least one footnote and check that the title for the footnotes section has been updated.
Docs
I'll update (if necessary) and reopen docs#445 if this passes.