Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include trailingSlash in astro:build:done hook #4553

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • When calculating the pages for the pages prop in astro:build:done account for the trailingSlash and build.format configs.
  • This fixes integrations like sitemaps which need the correct production URLs.
  • Closes Sitemap integration missing trailing slashes #4539

Testing

  • Test added in the sitemap integration to cover every scenario

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2022

🦋 Changeset detected

Latest commit: ac2bbd4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Aug 30, 2022
@matthewp matthewp marked this pull request as ready for review August 30, 2022 14:29
@matthewp matthewp merged commit 2f05f5d into main Aug 30, 2022
@matthewp matthewp deleted the sitemap-trailing-slash branch August 30, 2022 15:45
@astrobot-houston astrobot-houston mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sitemap integration missing trailing slashes
2 participants