Allow custom 404 route to handle API route missing methods #4594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a9ca414 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
Looks like the tests are failing |
|
I'd suggest there be another way to handle this. Serving a 404 page might be appropriate for a user navigating with a web browser to a missing page, but it's not appropriate to respond to, for example, a DELETE request to an incorrect API URL. |
1 task
matthewp
force-pushed
the
404-wrong-method
branch
from
f8a83a1 to
d5119e5
Compare
matthewp
force-pushed
the
404-wrong-method
branch
from
d5119e5 to
2d8362a
Compare
tony-sull
reviewed
Sep 14, 2022
|
@tony-sull I guess my main thought is that if we don't return the custom 404 page people will report that as a bug. I think the expectation is that all 404s go through 404.astro. I think we should prioritize correctness here. |
tony-sull
approved these changes
Sep 14, 2022
|
Thanks @tony-sull |
Merged
mrienstra
pushed a commit
to mrienstra/astro
that referenced
this pull request
Sep 14, 2022
…#4594) * Properly allow file uploads in the dev server * Allow custom 404 route to handle API route missing methods * Add a changeset * what was i thinking * Pass through the pathname * Move the try/catch out and into handleRequest * await the result of handleRoute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs
N/A, bug fix