Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for suffix hydration #4982

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Add test for suffix hydration #4982

merged 2 commits into from
Oct 6, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 5, 2022

Changes

Close #4785

The issue is already fixed by #4918, add a test so we don't break it on further refactors.

Testing

yes

Docs

N/A

@bluwy bluwy mentioned this pull request Oct 5, 2022
Closed
1 task
@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: e4cebbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 5, 2022
@matthewp matthewp merged commit 9683ae6 into main Oct 6, 2022
@matthewp matthewp deleted the test-suffix branch October 6, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suffixing JSX files with .react.tsx, .preact.tsx, .solid.tsx breaks hydration
2 participants
@bluwy @matthewp