Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing multiple doctype injections in single file #5035

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

AirBorne04
Copy link
Contributor

@AirBorne04 AirBorne04 commented Oct 10, 2022

Changes

  • limiting doctype injection to the first occurrence of html string

Testing

with the example from the solid framework (by adding the cloudflare adapter)

Docs

just a simple fix, so no doc update required.

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2022

🦋 Changeset detected

Latest commit: 59fba18

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 10, 2022
@AirBorne04
Copy link
Contributor Author

this is fixing the error from issue #5025

Copy link
Contributor

@aFuzzyBear aFuzzyBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 Belter,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants