Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure astro-island scripts render when using Astro.slots.render #5326

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Nov 8, 2022

Changes

Testing

  • New test case added to existing slot rendering tests.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2022

🦋 Changeset detected

Latest commit: 5408711

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2022

🦋 Changeset detected

Latest commit: 5408711

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 8, 2022
@matthewp matthewp marked this pull request as ready for review November 8, 2022 16:24
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, nice fix!

@matthewp matthewp merged commit 88c1bbe into main Nov 8, 2022
@matthewp matthewp deleted the slot-render-hydration branch November 8, 2022 17:15
@astrobot-houston astrobot-houston mentioned this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Astro.slots.render prevents islands hydration
2 participants