Fix duplicate alt attribute on Picture component. #6157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4d5da9b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
|
This is so tiny that it might be easier to just go make the change yourselves. |
Nah, you wrote the fix, you should get credit! Thanks for contributing!! |
natemoo-re
approved these changes
Feb 6, 2023
|
You’re welcome.
… On 7/02/2023, at 12:13, Nate Moore ***@***.***> wrote:
This is so tiny that it might be easier to just go make the change yourselves.
Nah, you made the code, you should get credit! Thanks for contributing!!
—
Reply to this email directly, view it on GitHub <#6157 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAHIOZZMPEWDOSY3J2DZSLWWGASRANCNFSM6AAAAAAUTIJRVA>.
You are receiving this because you authored the thread.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In
packages/integrations/image/components/Picture.astroon line 44,{...image}already includes thealtattribute, so including it again creates a duplicate which causes the output to fail HTML validation:<img alt="" alt="" ...Removing
{alt}(see changes below) solves the problem.Testing
Do you really want to add a test to test for duplicate attributes? The current tests should confirm that the
altattribute is not missing, which should be sufficient to prove that the{alt}code mentioned above was superfluous.I ran the tests (thank you for using pnpm!) and they passed. I'm sure you'll run them, too.
Docs
There is no reason for this to be discussed in the docs. It's a simple mistake, and this PR fixes it.