fix(html): Export HTML components as default export so their type is valid JSX #7296
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e744678 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
The change makes sense to me, but it looks like the tests are failing. |
Seems to be Solid tests, weird. I'll take a look |
|
I honestly have no idea. Any clue what that could be @natemoo-re? |
matthewp
approved these changes
Jun 5, 2023
bluwy
reviewed
Jun 5, 2023
Co-authored-by: Bjorn Lu <[email protected]>
bluwy
approved these changes
Jun 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The export shape for HTML component is an object with a
renderfunction on it, this is very cool but unfortunately, it's an invalid type for JSX. This PR changes it to be a default exported function instead, which doesn't change the usage.This PR also includes a small change to the type reference in
env.d.tsto point toclient-base.d.tsinstead ofclient.d.ts, as the later includes some definitions that we should be overwriting later onFix withastro/language-tools#447
Fix withastro/language-tools#557
Testing
Tests should still pass!
Docs
N/A