Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add progress to asset generation #8357

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

itsmatteomanf
Copy link
Contributor

Changes

Added counter to show progress for assets image generation.
Fixed small unit of measurement error.

Testing

No tests are necessary, the change is minimal and just to logging.

Docs

No documentation changes are needed, adds info to logging.

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: 933beb9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@itsmatteomanf itsmatteomanf changed the title I/assets/log improvements feat: add progress to asset generation Sep 1, 2023
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 1, 2023
@Diamondbrandblue
Copy link

Log improvements yes

Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, this looks great!

@itsmatteomanf
Copy link
Contributor Author

My pleasure! :)

@Princesseuh Princesseuh merged commit 6b1e798 into withastro:main Sep 1, 2023
@astrobot-houston astrobot-houston mentioned this pull request Sep 1, 2023
@itsmatteomanf itsmatteomanf deleted the i/assets/log-improvements branch May 18, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants