Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure chunkFileNames do not include invalid characters #8366

Merged
merged 9 commits into from
Sep 1, 2023
Merged

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Sep 1, 2023

Changes

  • We were getting reports of the @astrojs/netlify adapter being totally broken for server and hybrid deployments.
  • Turns out Astro would sometimes emit chunks with invalid characters @_@ which Netlify choked on
  • The fix is to ensure chunkFileNames sanitizes the filename first
  • Also changes our chunk asset filenames from something like dist/server/chunks/index@_@astro.[hash].[ext] to something like dist/server/chunks/index_hash.[ext]
  • Notable change is [name].[hash].[ext] to [name]_[hash].[ext]
  • Changeset added!

Testing

Tested manually with community reproductions. It works!

Docs

Bug fix only, will alert folks!

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: 73a003f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 1, 2023
@natemoo-re
Copy link
Member Author

!preview sanitize-filenames

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

 > [email protected] release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--sanitize-filenames" > [email protected] build /home/runner/work/astro/astro > turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote caching enabled�[0m ::group::@astrojs/internal-helpers:build cache hit, suppressing logs �[2m32b1108bc9e1f437�[0m ::endgroup:: ::group::@astrojs/prism:build cache hit, suppressing logs �[2m846972649e641897�[0m ::endgroup:: ::group::create-astro:build cache hit, suppressing logs �[2m7cd1fc32bb1de456�[0m ::endgroup:: ::group::@astrojs/markdown-remark:build cache hit, suppressing logs �[2mbdafb901dff64766�[0m ::endgroup:: ::group::@astrojs/telemetry:build cache miss, executing �[2m0abdd6af0cba6a05�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/telemetry > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::astro:build cache miss, executing �[2m32c1984bb4df2f29�[0m > [email protected] build /home/runner/work/astro/astro/packages/astro > pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild > [email protected] prebuild /home/runner/work/astro/astro/packages/astro > astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" > [email protected] postbuild /home/runner/work/astro/astro/packages/astro > astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm" ::endgroup:: ::group::@astrojs/alpinejs:build cache miss, executing �[2ma7e929392bfe9ec2�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/alpinejs > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/lit:build cache miss, executing �[2m49ebc90076e451d1�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/lit > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/deno:build cache miss, executing �[2m53b9aecd0c78eceb�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/deno > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@benchmark/timer:build cache miss, executing �[2m12f4c65886f817b9�[0m > @benchmark/[email protected] build /home/runner/work/astro/astro/benchmark/packages/timer > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/partytown:build cache miss, executing �[2m15a1e254517abc52�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/partytown > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/solid-js:build cache miss, executing �[2m5ba32a7c48da89fc�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/solid > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/preact:build cache miss, executing �[2m0776c27e79f3455a�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/preact > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vercel:build cache miss, executing �[2mebf8f10e0eedb0ec�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/vercel > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vue:build cache miss, executing �[2m84edc79c61edc6a7�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/vue > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/svelte:build cache miss, executing �[2m49d03fd6195a3f80�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/svelte > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/prefetch:build cache miss, executing �[2m4b9df5a9dcb14632�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/prefetch > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/underscore-redirects:build cache miss, executing �[2md02f3c4889ca0f68�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/underscore-redirects > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::@astrojs/react:build cache miss, executing �[2m8ee14353a3dd176c�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/react > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/tailwind:build cache miss, executing �[2m2cea529f52868c8c�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/tailwind > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/rss:build cache miss, executing �[2m8edfa92d50b22e67�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/astro-rss > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/mdx:build cache miss, executing �[2ma1be67a3ad316cb3�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/mdx > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/node:build cache miss, executing �[2m4b9e17dcb8d90e0d�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/node > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/markdoc:build cache miss, executing �[2m0f2eae1227064369�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/markdoc > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/netlify:build cache miss, executing �[2m97d08f67bb7b89a6�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/netlify > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/cloudflare:build cache miss, executing �[2maf02e4470d24e480�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/cloudflare > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/sitemap:build cache miss, executing �[2m4d01c4de27dc2c1b�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/sitemap > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: Tasks: 27 successful, 27 total Cached: 4 cached, 27 total Time: 1m20.226s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--sanitize-filenames tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/markdoc 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/internal-helpers 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/underscore-redirects 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-sanitize-filenames-20230901201147) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m create-astro is not being published because version 4.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.3.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/cloudflare is being published because our local version (0.0.0-sanitize-filenames-20230901201147) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdoc is not being published because version 0.5.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 1.0.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/netlify is being published because our local version (0.0.0-sanitize-filenames-20230901201147) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 6.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.4.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 4.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 4.0.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/internal-helpers is not being published because version 0.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 3.0.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/telemetry is being published because our local version (0.0.0-sanitize-filenames-20230901201147) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/underscore-redirects is not being published because version 0.3.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-sanitize-filenames-20230901201147"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/cloudflare"�[39m at �[32m"0.0.0-sanitize-filenames-20230901201147"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/netlify"�[39m at �[32m"0.0.0-sanitize-filenames-20230901201147"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/telemetry"�[39m at �[32m"0.0.0-sanitize-filenames-20230901201147"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 [email protected] 🦋 @astrojs/[email protected] 🦋 @astrojs/[email protected] 🦋 @astrojs/[email protected] 🦋 Creating git tags... 🦋 New tag: [email protected] 🦋 New tag: @astrojs/[email protected] 🦋 New tag: @astrojs/[email protected] 🦋 New tag: @astrojs/[email protected]

@natemoo-re
Copy link
Member Author

!preview sanitize-filenames

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

 > [email protected] release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--sanitize-filenames" > [email protected] build /home/runner/work/astro/astro > turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/internal-helpers, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/underscore-redirects, @astrojs/vercel, @astrojs/vue, @benchmark/timer, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote caching enabled�[0m ::group::@astrojs/internal-helpers:build cache hit, suppressing logs �[2m32b1108bc9e1f437�[0m ::endgroup:: ::group::@astrojs/prism:build cache hit, suppressing logs �[2m846972649e641897�[0m ::endgroup:: ::group::create-astro:build cache hit, suppressing logs �[2m7cd1fc32bb1de456�[0m ::endgroup:: ::group::@astrojs/markdown-remark:build cache hit, suppressing logs �[2mbdafb901dff64766�[0m ::endgroup:: ::group::@astrojs/telemetry:build cache miss, executing �[2me1823de5a5b3aa8e�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/telemetry > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::astro:build cache miss, executing �[2mee316df99980fe7d�[0m > [email protected] build /home/runner/work/astro/astro/packages/astro > pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild > [email protected] prebuild /home/runner/work/astro/astro/packages/astro > astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" > [email protected] postbuild /home/runner/work/astro/astro/packages/astro > astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm" ::endgroup:: ::group::@astrojs/alpinejs:build cache miss, executing �[2m50e67c248106615e�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/alpinejs > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/lit:build cache miss, executing �[2m8644e1411c2bdf79�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/lit > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/tailwind:build cache miss, executing �[2m495b48cbb61655a3�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/tailwind > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/underscore-redirects:build cache miss, executing �[2m0d82c6b60bbad9d1�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/underscore-redirects > astro-scripts build "src/**/*.ts" && tsc -p tsconfig.json ::endgroup:: ::group::@astrojs/partytown:build cache miss, executing �[2m7af87fde5b243846�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/partytown > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/solid-js:build cache miss, executing �[2m727f2569c52dfe64�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/solid > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/preact:build cache miss, executing �[2mdb385a8bbb03ba47�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/preact > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/node:build cache miss, executing �[2ma2c2380668dfb07e�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/node > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vue:build cache miss, executing �[2mccfb46b29c939286�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/vue > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@astrojs/svelte:build cache miss, executing �[2m59f31aa6302493a3�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/svelte > astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc ::endgroup:: ::group::@benchmark/timer:build cache miss, executing �[2md5c91c3ce44a8103�[0m > @benchmark/[email protected] build /home/runner/work/astro/astro/benchmark/packages/timer > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/rss:build cache miss, executing �[2m80e8ae744df6231a�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/astro-rss > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/prefetch:build cache miss, executing �[2m1a3b6fee80d3da32�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/prefetch > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/deno:build cache miss, executing �[2m256bb02ad937025e�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/deno > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/react:build cache miss, executing �[2mceeb16305182f103�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/react > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/mdx:build cache miss, executing �[2m4465021a4efcd25a�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/mdx > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/vercel:build cache miss, executing �[2mad37644783593151�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/vercel > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/markdoc:build cache miss, executing �[2m6a9e85b900aae740�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/markdoc > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/netlify:build cache miss, executing �[2md69070eee9854329�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/netlify > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/cloudflare:build cache miss, executing �[2md2573198b331a980�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/cloudflare > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: ::group::@astrojs/sitemap:build cache miss, executing �[2m9a5ba13abfe1bbdb�[0m > @astrojs/[email protected] build /home/runner/work/astro/astro/packages/integrations/sitemap > astro-scripts build "src/**/*.ts" && tsc ::endgroup:: Tasks: 27 successful, 27 total Cached: 4 cached, 27 total Time: 1m5.987s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--sanitize-filenames tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/markdoc 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/internal-helpers 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/underscore-redirects 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-sanitize-filenames-20230901203435) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m create-astro is not being published because version 4.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.3.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/cloudflare is being published because our local version (0.0.0-sanitize-filenames-20230901203435) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdoc is not being published because version 0.5.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 1.0.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/netlify is being published because our local version (0.0.0-sanitize-filenames-20230901203435) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 6.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.4.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 4.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 5.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 4.0.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/internal-helpers is not being published because version 0.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 3.0.0 is already published on npm 🦋 �[36minfo�[39m @astrojs/telemetry is being published because our local version (0.0.0-sanitize-filenames-20230901203435) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/underscore-redirects is not being published because version 0.3.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-sanitize-filenames-20230901203435"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/cloudflare"�[39m at �[32m"0.0.0-sanitize-filenames-20230901203435"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/netlify"�[39m at �[32m"0.0.0-sanitize-filenames-20230901203435"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/telemetry"�[39m at �[32m"0.0.0-sanitize-filenames-20230901203435"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 [email protected] 🦋 @astrojs/[email protected] 🦋 @astrojs/[email protected] 🦋 @astrojs/[email protected] 🦋 Creating git tags... 🦋 New tag: [email protected] 🦋 New tag: @astrojs/[email protected] 🦋 New tag: @astrojs/[email protected] 🦋 New tag: @astrojs/[email protected]

@natemoo-re
Copy link
Member Author

Tests will need to be updated to match this expected format [name]_[hash] instead of [name].[hash]

Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RE-APPROVED

@natemoo-re natemoo-re merged commit c563343 into main Sep 1, 2023
@natemoo-re natemoo-re deleted the fix/netlify branch September 1, 2023 23:13
@astrobot-houston astrobot-houston mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants