-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure chunkFileNames
do not include invalid characters
#8366
Conversation
🦋 Changeset detectedLatest commit: 73a003f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview sanitize-filenames |
|
!preview sanitize-filenames |
|
Tests will need to be updated to match this expected format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RE-APPROVED
Changes
@astrojs/netlify
adapter being totally broken forserver
andhybrid
deployments.@_@
which Netlify choked onchunkFileNames
sanitizes the filename firstdist/server/chunks/index@_@astro.[hash].[ext]
to something likedist/server/chunks/index_hash.[ext]
[name].[hash].[ext]
to[name]_[hash].[ext]
Testing
Tested manually with community reproductions. It works!
Docs
Bug fix only, will alert folks!