Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudflare): target es2022 instead of es2020 to fix esbuild incompatibility issues #8682

Merged
merged 10 commits into from
Sep 28, 2023
Merged

fix(cloudflare): target es2022 instead of es2020 to fix esbuild incompatibility issues #8682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
859f217
fix(cloudflare): target es2022 instead of es2020 to fix esbuild incom…
dario-piotrowicz Sep 27, 2023
d5459a9
add changeset
dario-piotrowicz Sep 27, 2023
6618324
update changeset
alexanderniebuhr Sep 28, 2023
f4dc7a3
fix(cloudflare): change build target to es2022
alexanderniebuhr Sep 28, 2023
01fd55b
Merge branch 'main' into cloudflare-target
alexanderniebuhr Sep 28, 2023
72409c2
Merge branch 'main' into cloudflare-target
alexanderniebuhr Sep 28, 2023
5b81db0
Merge branch 'main' into cloudflare-target
alexanderniebuhr Sep 28, 2023
fcf9665
Merge branch 'main' into cloudflare-target
alexanderniebuhr Sep 28, 2023
6216037
Merge branch 'main' into cloudflare-target
alexanderniebuhr Sep 28, 2023
a94243c
Merge branch 'main' into cloudflare-target
alexanderniebuhr Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/orange-windows-battle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/cloudflare': minor
---

Change build target from `es2020` to `es2022`, for better support
4 changes: 2 additions & 2 deletions packages/integrations/cloudflare/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export default function createIntegration(args?: Options): AstroIntegration {
fileURLToPath(assetsUrl)
);
await esbuild.build({
target: 'es2020',
target: 'es2022',
platform: 'browser',
conditions: ['workerd', 'worker', 'browser'],
external: [
Expand Down Expand Up @@ -313,7 +313,7 @@ export default function createIntegration(args?: Options): AstroIntegration {
const finalBuildUrl = pathToFileURL(buildPath.replace(/\.mjs$/, '.js'));

await esbuild.build({
target: 'es2020',
target: 'es2022',
platform: 'browser',
conditions: ['workerd', 'worker', 'browser'],
external: [
Expand Down