Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removed adapters cleanup #8726

Merged
merged 3 commits into from
Oct 10, 2023
Merged

chore: removed adapters cleanup #8726

merged 3 commits into from
Oct 10, 2023

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Oct 2, 2023

Changes

Internal

Testing

Does not affect behavior.

Docs

Does not affect usage.

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9a70240

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: example Related to an example package (scope) 🚨 action Modifies GitHub Actions pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Oct 2, 2023
@github-actions github-actions bot removed the pkg: integration Related to any renderer integration (scope) label Oct 2, 2023
@lilnasy lilnasy force-pushed the chore/cleanup branch 2 times, most recently from 4c77682 to 8dc1fa7 Compare October 5, 2023 18:33
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 5, 2023
@lilnasy lilnasy marked this pull request as ready for review October 5, 2023 20:08
@lilnasy lilnasy requested a review from a team as a code owner October 5, 2023 20:08
matthewp
matthewp approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lilnasy lilnasy merged commit c071458 into withastro:main Oct 10, 2023
@lilnasy lilnasy deleted the chore/cleanup branch October 10, 2023 18:18
ematipico pushed a commit that referenced this pull request Feb 6, 2025
@lilnasy
chore: removed adapters cleanup (#8726)
30419b3 
* update ci, readme, comments, remote workspaces

* fix hosted test fixture

* keep adapter config typedocs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

@ematipico ematipico ematipico approved these changes

@alexanderniebuhr alexanderniebuhr Awaiting requested review from alexanderniebuhr

Assignees
No one assigned
Labels
🚨 action Modifies GitHub Actions pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilnasy @matthewp @ematipico @alexanderniebuhr