Fix: Retain focus for persisted input elements during view transitions #8813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2f8965e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
martrapp
commented
Oct 11, 2023
There was a problem hiding this comment.
Not really related to focus handling, but as I was going through the tests I noticed that we are running with output = server, when in fact almost all tests are static. So I marked the test that needs the server with prerender = false and changed to hybrid.
martrapp
commented
Oct 11, 2023
There was a problem hiding this comment.
The file was always called styles.css, but I noticed it only now
martrapp
commented
Oct 11, 2023
martrapp
changed the title
martrapp
changed the title
natemoo-re
approved these changes
Oct 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
An element with
transition:persistsurvives view transitions and continues its life on the next page. Its state is preserved. For example, aHTMLTextAreaElementretains the text entered up to that point. Unfortunately, persisted elements lose focus during the transition when they are removed from the DOM and reinserted.This fix saves the current focus and cursor position and restores them on the new page.
Testing
Added e2e test
Docs
n/a bug fix