refactor(i18n): breakdown routing strategy #9236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3f80577 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
ematipico
force-pushed
the
feat/change-strategy
branch
from
b67f46f to
92bf846
Compare
delucis
reviewed
Nov 29, 2023
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
delucis
approved these changes
Nov 29, 2023
matthewp
approved these changes
Nov 29, 2023
bluwy
approved these changes
Nov 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses RFC change: withastro/roadmap@089253d
Closes PLT-1269
Thanks to zod
.transform, the only changes are user-facing and logically it stays the same.The code changes I did are:
routingStrategytorouting, which is transformed in a string (we can then decide to change the string themselves, but it's only bikeshedding)Testing
All tests should pass after updating the configuration to use the new shape.
Docs
/cc @withastro/maintainers-docs for feedback!