Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent render ansi in error overlay #9547

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Prevent render ansi in error overlay #9547

merged 3 commits into from
Dec 30, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 29, 2023

Changes

fix #8915

Testing

Tested manually with the given repo. Updated look:

image

Docs

n/a. bug fix.

Copy link

changeset-bot bot commented Dec 29, 2023

🦋 Changeset detected

Latest commit: 4e70ea3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 29, 2023
@Princesseuh
Copy link
Member

Test failure seems valid

@bluwy
Copy link
Member Author

bluwy commented Dec 29, 2023

Seems to be good now. Somehow esbuild errors are instanceof Error but they don't have the name and message property 😲

@bluwy bluwy merged commit 22f42d1 into main Dec 30, 2023
13 checks passed
@bluwy bluwy deleted the error-ansi-begone branch December 30, 2023 11:06
@astrobot-houston astrobot-houston mentioned this pull request Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken text in error overlay
2 participants