refactor: remove endpoint handling infra #9775
Conversation
🦋 Changeset detectedLatest commit: c1c91fa The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
There was a problem hiding this comment.
Refactors should not have changelogs, since users don't need to know about these refactors
There was a problem hiding this comment.
I went back and forth on this. We can't say ever say for sure, there won't be regression and the changelog comes in handy. At the end, it's just another entry in the changelog.
| }); | ||
| } | ||
| if (REROUTABLE_STATUS_CODES.has(response.status) && response.headers.get("X-Astro-Reroute") !== "no") { | ||
| return this.#renderError(request, { |
There was a problem hiding this comment.
Why did we remove the routeData.type === 'page' || routeData.type === 'redirect' check?
There was a problem hiding this comment.
That was there to carve out endpoints from the rerouting behavior. That does not happen anymore.
| const response = await handler.call(mod, context); | ||
| // Endpoints explicitly returning 404 or 500 response status should | ||
| // NOT be subject to rerouting to 404.astro or 500.astro. | ||
| response.headers.set("X-Astro-Reroute", "no"); |
There was a problem hiding this comment.
We might as well move X-Astro-Reroute to a const at this point, to avoid possible typos
There was a problem hiding this comment.
That's a good idea. I can do that in a future PR.
Changes
Pipelineimplemented once for each environment.callEndpointcreated a response with a special header. The endpoint handler recognises the special header and throws a special error. ThenApprecognises the special error and finally performs the rerouting.callEndpointcreates a response with a special header ("X-Astro-Reroute=no"), and App recognises it to perform the rerouting directly.Testing
Does not affect behavior. Existing tests should pass.
Docs
Does not affect usage.