fix: handle module IDs containing quotes #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 468b57a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
approved these changes
Dec 28, 2022
Comment on lines
+2494
to
+2495
| escapedModuleId := strings.ReplaceAll(tt.moduleId, "'", "\\'") | ||
| toMatch += suffixWithModuleId(escapedModuleId) |
There was a problem hiding this comment.
I think for complete correctness we might want to use:
but since this is a file path, it would almost always not have double backslashes to mess up the replacements, so I think this is fine for now.
natemoo-re
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs
its possible you can have a file named
foo'bar.astrowhich currently will trip up the compiler, since it'd produce something along the lines ofcreateComponent(..., 'foo'bar')(ofc syntactically incorrect).let me know if this is the wrong way to fix it and i'll update
i also added an
editorconfig, let me know if its wrong. it'd be useful to have one in this repo so contributors automatically use the right indentation etc