-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong code example for persist in cloudflare.mdx #10601
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Thank you @Rados51 for letting us know what worked for you! I was not able to find this myself in the Cloudflare docs to confirm, so I'll ask @alexanderniebuhr if he is able to confirm this for us! |
https://developers.cloudflare.com/workers/wrangler/api/
persist?: boolean | {
path: string;
}; By passing just string in |
@Rados51 Thank you, that's really helpful! Looks good to me! Really appreciate you taking the time and effort to contribute, and happy to welcome you to Team Docs! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with Cloudflare docs!
Thank you too @sarah11918 🙌🏻 |
Thanks @Rados51. We updated the code, due to a breaking change by Cloudflare, but forgot the docs! |
Description
I was following docs and did not realize it was wrongly documented until I looked through types.